Skip to content
This repository was archived by the owner on Apr 7, 2026. It is now read-only.

chore: remove additional lock in multiplexed session background maint… - #3060

Merged
gcf-merge-on-green[bot] merged 2 commits into
googleapis:mainfrom
arpan14:mux-fix-lock
Apr 24, 2024
Merged

chore: remove additional lock in multiplexed session background maint…#3060
gcf-merge-on-green[bot] merged 2 commits into
googleapis:mainfrom
arpan14:mux-fix-lock

Conversation

@arpan14

@arpan14 arpan14 commented Apr 23, 2024

Copy link
Copy Markdown
Contributor

We are not updating the value of multiplexed session within the background thread. So there is no need to hold a lock. Removing this lock can potentially improve performance.

@arpan14
arpan14 requested a review from a team April 23, 2024 13:49
@product-auto-label product-auto-label Bot added size: s Pull request size is small. api: spanner Issues related to the googleapis/java-spanner API. labels Apr 23, 2024
@arpan14
arpan14 requested a review from olavloite April 23, 2024 13:50
@arpan14 arpan14 added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 24, 2024
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 24, 2024
@arpan14
arpan14 requested a review from a team April 24, 2024 08:38
@arpan14 arpan14 added the automerge Merge the pull request once unit tests and other checks pass. label Apr 24, 2024
@gcf-merge-on-green
gcf-merge-on-green Bot merged commit 303cc15 into googleapis:main Apr 24, 2024
@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Apr 24, 2024
@arpan14
arpan14 deleted the mux-fix-lock branch April 24, 2024 09:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: spanner Issues related to the googleapis/java-spanner API. size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants