build: move hermetic_library_generation filtering logic into the steps rather than on.pull_request#3410
Merged
BenWhitehead merged 3 commits intomainfrom Dec 2, 2025
Merged
Conversation
|
Warning: This pull request is touching the following templated files:
|
product-auto-label
Bot
added
size: s
BenWhitehead
force-pushed
the
build/hermetic-config
branch
4 times, most recently
from
031e01d to
888f716
Compare
…s rather than on.pull_request When filtering with on.pull_request the workflow will not report a status if it does not match. This causes contention with this workflow being declared as a required status. To sidestep this, move the matching logic into the steps of the workflow, similar to how we filter out PRs from forks.
BenWhitehead
force-pushed
the
build/hermetic-config
branch
from
888f716 to
34520a7
Compare
blakeli0
approved these changes
Dec 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When filtering with on.pull_request the workflow will not report a status if it does not match. This causes contention with this workflow being declared as a required status. To sidestep this, move the matching logic into the steps of the workflow, similar to how we filter out PRs from forks.