Skip to content

chore(internal/librarian/rust): remove unused function - #3306

Merged
zhumin8 merged 1 commit into
mainfrom
rm-unused
Dec 19, 2025
Merged

chore(internal/librarian/rust): remove unused function#3306
zhumin8 merged 1 commit into
mainfrom
rm-unused

Conversation

@zhumin8

@zhumin8 zhumin8 commented Dec 18, 2025

Copy link
Copy Markdown
Contributor

Removes getPackageName that retrieves the packagename from a Cargo.toml file. It is never used other than test.

For #3203

@zhumin8
zhumin8 requested a review from a team as a code owner December 18, 2025 19:16
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @zhumin8, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on code hygiene by eliminating an unused function and its related dependencies and tests within the internal/librarian/rust package. The getPackageName function was identified as dead code, only being used in its own test, and its removal simplifies the codebase and reduces the overall dependency footprint without impacting functionality.

Highlights

  • Code Removal: The getPackageName function, which was responsible for extracting the package name from a Cargo.toml file, has been entirely removed from internal/librarian/rust/helper.go.
  • Dependency Cleanup: Associated unused imports, specifically the os package and the github.com/pelletier/go-toml/v2 library, have been removed from internal/librarian/rust/helper.go.
  • Test Removal: The TestGetPackageName unit test in internal/librarian/rust/helper_test.go has been removed, as the function it tested no longer exists.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly removes the unused getPackageName function and its associated test, which is a good code cleanup. I've added one comment suggesting the removal of related data structures that are now also unused as a result of this change.

I am having trouble creating individual review comments. Click here to see my feedback.

internal/librarian/rust/helper.go (48-60)

medium

Good catch removing this unused function. With getPackageName gone, the structs CargoConfig and CargoPackage defined on lines 101-108 are no longer used and should also be removed to complete the code cleanup.

@codecov

codecov Bot commented Dec 18, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.43%. Comparing base (07dd3ac) to head (6de155d).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3306      +/-   ##
==========================================
+ Coverage   80.41%   80.43%   +0.01%     
==========================================
  Files         163      163              
  Lines       13773    13764       -9     
==========================================
- Hits        11076    11071       -5     
+ Misses       2120     2118       -2     
+ Partials      577      575       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zhumin8
zhumin8 merged commit 3c2d0e4 into main Dec 19, 2025
11 checks passed
@zhumin8
zhumin8 deleted the rm-unused branch December 19, 2025 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants