fix(previews): set initial version on add#5232
Merged
noahdietz merged 3 commits intogoogleapis:mainfrom Apr 9, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request implements automatic version derivation for preview libraries. The addPreviewLibrary function now utilizes the semver package to calculate an initial preview version based on the stable version. Test cases in add_test.go have been updated to reflect these versioning changes. I have no feedback to provide.
quirogas
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rather than letting the
previewlibrary to accidentally resolve its version from the containing stable, set it to a reasonable initial value derived from the containing stable version.We may need to implement per-language
switchfor this inaddPreviewLibrarye.g. if future languages use a different prerelease suffix.Should've been done as part of #4986
Toward #4867