feat(tool/cmd/migrate): set php default for common_resources - #6836
Merged
zhumin8 merged 1 commit intoJul 15, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the PHP migration configuration by adding a default setting for common_resources in librarian_php.yaml and updating the corresponding unit test in php_test.go to verify this new default configuration. There are no review comments, and I have no feedback to provide.
sofisl
approved these changes
Jul 15, 2026
zhumin8
marked this pull request as ready for review
July 15, 2026 20:57
yangyzs
pushed a commit
that referenced
this pull request
Jul 17, 2026
🤖 I have created a release *beep* *boop* --- ## [0.27.0](v0.26.0...v0.27.0) (2026-07-17) ### Features * **internal/config:** add additional_protos configuration support for php ([#6801](#6801)) ([26c1029](26c1029)), closes [#6743](#6743) * **internal/librarian/golang:** support protoc tool configuration ([#6767](#6767)) ([7013350](7013350)) * **internal/librarian/java:** populate RequiresBilling from API config in README template ([#6737](#6737)) ([da3bc04](da3bc04)) * **internal/librarian/java:** pre-validate java libraries bom version in config ([#6674](#6674)) ([620a505](620a505)) * **internal/librarian/nodejs:** support src_dir for pnpm tool sourcebuilds ([#6877](#6877)) ([c58e52d](c58e52d)) * **internal/librarian/php:** add tidying logic for additional_protos ([#6819](#6819)) ([ec61444](ec61444)), closes [#6743](#6743) * **internal/librarian/php:** install tools using composer ([#6799](#6799)) ([482238f](482238f)) * **internal/librarian/php:** integrate additional_protos into client generation ([#6810](#6810)) ([51bfdd2](51bfdd2)), closes [#6743](#6743) * **internal/librarian/php:** make CommonResources configurable for php ([#6823](#6823)) ([f30d232](f30d232)), closes [#6813](#6813) * **internal/librarian/php:** run owlbot.py in generate phase ([#6869](#6869)) ([2d4b208](2d4b208)), closes [#6773](#6773) * **internal/librarian/php:** support install PNPM tools ([#6839](#6839)) ([192e469](192e469)), closes [#6830](#6830) * **librarian:** config get libraries apiPath ([#6655](#6655)) ([e5cd774](e5cd774)) * **sidekick/rust:** generate LRO `Poller` for bigquery `InsertJob` ([#6841](#6841)) ([d5ce8a9](d5ce8a9)) * **sidekick/swift:** `oneof` in method signatures ([#6863](#6863)) ([9ebd4bc](9ebd4bc)) * **sidekick/swift:** generate core package versions ([#6812](#6812)) ([1a08672](1a08672)), closes [#5940](#5940) * **sidekick/swift:** generate telemetry headers ([#6820](#6820)) ([b24d086](b24d086)) * **sidekick/swift:** use `$apiVersion` ([#6794](#6794)) ([0b309b8](0b309b8)) * **sidekick/swift:** use internal import over @_implementationOnly ([#6817](#6817)) ([096d91c](096d91c)) * **swift:** add convert-swift functionality ([#6802](#6802)) ([7813442](7813442)) * **swift:** format all module output directories ([#6840](#6840)) ([eb684c9](eb684c9)) * **too/cmd/migrate:** specify protoc version in tools section ([#6793](#6793)) ([201fa99](201fa99)), closes [#6791](#6791) * **tool/cmd/migrate:** add prettier formatting tools to PHP migration template ([#6831](#6831)) ([9c06b20](9c06b20)) * **tool/cmd/migrate:** discover ruby libraries during migration ([#6856](#6856)) ([fefcc0e](fefcc0e)), closes [#6632](#6632) * **tool/cmd/migrate:** parse BUILD.bazel and populate AdditionalProtos for php ([#6814](#6814)) ([53e3f4b](53e3f4b)), closes [#6743](#6743) * **tool/cmd/migrate:** set php default for common_resources ([#6836](#6836)) ([b2df615](b2df615)), closes [#6813](#6813) ### Bug Fixes * **.github:** restore pnpm version ([#6851](#6851)) ([0735cac](0735cac)) * **internal/config:** remove PHPPackage.AdditionalProtos and simplify logic ([#6818](#6818)) ([19c4a93](19c4a93)), closes [#6743](#6743) * **internal/librarian/nodejs:** fallback to Checksum if SHA256 is empty ([#6804](#6804)) ([cf906e6](cf906e6)), closes [#6803](#6803) * **internal/librarian/nodejs:** pass --no-comments to compileProtos ([#6866](#6866)) ([e749b3e](e749b3e)) * **sidekick/swift:** clashes for `Logging` ([#6878](#6878)) ([faf0c22](faf0c22)) * **sidekick/swift:** dependencies on `Clients.swift` ([#6864](#6864)) ([c5bca34](c5bca34)) * **sidekick/swift:** no escaping for `GateExpression` ([#6829](#6829)) ([b26b680](b26b680)) * **sidekick/swift:** skip external package traits ([#6848](#6848)) ([ba9041c](ba9041c)) * **tool/cmd/migrate:** add SHA256 for protoc version in php migrate ([#6798](#6798)) ([0a47b2f](0a47b2f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a global default to
common_resourcesto true.Will do followup to parse per API value from BUILD.bazel. This global default un-blocks testing with generate.
For #6813