This repository was archived by the owner on Sep 19, 2023. It is now read-only.
fix!: remove CreateIosAppDataStream, CreateAndroidAppDataStream methods from the API#105
Merged
SurferJeffAtGoogle merged 2 commits intomasterfrom Apr 28, 2021
Conversation
…ethods from the API feat: add `SearchChangeHistoryEvents` method to the API fix!: update `DeleteProperty` method to return the deleted property data as `Property` type instead of returning an empty response feat: add `ActorType`, `ActionType`, `ChangeHistoryResourceType`, `ChangeHistoryEvent`, `ChangeHistoryChange` types used by `SearchChangeHistoryEvents` method fix!: update `time_zone` field of `Property` type to be required feat: add `delete_time`, `expire_time` output only fields to `Property` type fix!: remove `deleted` field from `Property` type PiperOrigin-RevId: 370749341 Source-Link: googleapis/googleapis@2375bb4 Source-Link: https://github.com/googleapis/googleapis-gen/commit/ee560452477d92572edb133386e7129532db8ba6
trusted-contributions-gcf
Bot
added
the
kokoro:force-run
product-auto-label
Bot
added
the
api: analyticsadmin
google-cla
Bot
added
the
cla: yes
yoshi-kokoro
removed
the
kokoro:force-run
trusted-contributions-gcf
Bot
added
the
kokoro:force-run
Codecov Report
@@ Coverage Diff @@
## master #105 +/- ##
==========================================
- Coverage 98.23% 98.21% -0.02%
==========================================
Files 5 5
Lines 7015 7055 +40
Branches 245 243 -2
==========================================
+ Hits 6891 6929 +38
- Misses 123 125 +2
Partials 1 1
Continue to review full report at Codecov.
|
SurferJeffAtGoogle
changed the title
CreateIosAppDataStream, CreateAndroidAppDataStream methods from the API feat: add SearchChangeHistoryEvents method to the API fix!: update DeleteProperty method to return the deleted property data as Property type instead of returning an empty response feat: add ActorType, ActionType, ChangeHistoryResourceType, ChangeHistoryEvent, ChangeHistoryChange types used by SearchChangeHistoryEvents method fix!: update time_zone field of Property type to be required feat: add delete_time, expire_time output only fields to Property type fix!: remove deleted field from Property typeCreateIosAppDataStream, CreateAndroidAppDataStream methods from the API
SurferJeffAtGoogle
approved these changes
Apr 28, 2021
SurferJeffAtGoogle
added
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
SurferJeffAtGoogle
deleted the
owl-bot-b23ca9a2-b955-414f-8736-eb14dfa4bdc9
branch
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: add
SearchChangeHistoryEventsmethod to the APIfix!: update
DeletePropertymethod to return the deleted property data asPropertytype instead of returning an empty responsefeat: add
ActorType,ActionType,ChangeHistoryResourceType,ChangeHistoryEvent,ChangeHistoryChangetypes used bySearchChangeHistoryEventsmethodfix!: update
time_zonefield ofPropertytype to be required feat: adddelete_time,expire_timeoutput only fields toPropertytypefix!: remove
deletedfield fromPropertytypePiperOrigin-RevId: 370749341
Source-Link: googleapis/googleapis@2375bb4
Source-Link: https://github.com/googleapis/googleapis-gen/commit/ee560452477d92572edb133386e7129532db8ba6