Skip to content
This repository was archived by the owner on Sep 19, 2023. It is now read-only.

chore: release 3.0.0#109

Merged
sofisl merged 1 commit intomasterfrom
release-v3.0.0
Jun 1, 2021
Merged

chore: release 3.0.0#109
sofisl merged 1 commit intomasterfrom
release-v3.0.0

Conversation

@release-please
Copy link
Copy Markdown
Contributor

@release-please release-please Bot commented Apr 28, 2021 •
edited
Loading

🤖 I have created a release *beep* *boop*

3.0.0 (2021-05-27)

⚠ BREAKING CHANGES

Features

Bug Fixes

  • deps: require google-gax v2.12.0 (#110) (cec8b6a)
  • GoogleAdsError missing using generator version after 1.3.0 (#118) (f69d3e9)
  • remove CreateIosAppDataStream, CreateAndroidAppDataStream methods from the API (#105) (c6c1883)
  • use require() to load JSON protos (#112) (904aaf6)

This PR was generated with Release Please. See documentation.

@release-please release-please Bot requested a review from a team April 28, 2021 17:29
@trusted-contributions-gcf trusted-contributions-gcf Bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 28, 2021
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Apr 28, 2021
@product-auto-label product-auto-label Bot added the api: analyticsadmin Issues related to the googleapis/nodejs-analytics-admin API. label Apr 28, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 28, 2021
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 28, 2021 •
edited
Loading

Codecov Report

Merging #109 (d0fa8ea) into master (7449bba) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head d0fa8ea differs from pull request most recent head f3bacd5. Consider uploading reports for the commit f3bacd5 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #109      +/-   ##
==========================================
- Coverage   98.19%   98.19%   -0.01%     
==========================================
  Files           5        5              
  Lines        6999     6985      -14     
  Branches      243      241       -2     
==========================================
- Hits         6873     6859      -14     
  Misses        125      125              
  Partials        1        1
Impacted Files Coverage Δ
src/v1alpha/analytics_admin_service_client.ts 98.50% <100.00%> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7c4e29...f3bacd5. Read the comment docs.

@bcoe bcoe closed this Apr 28, 2021
@bcoe bcoe reopened this Apr 28, 2021
@trusted-contributions-gcf trusted-contributions-gcf Bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 28, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 28, 2021
@bcoe bcoe added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Apr 28, 2021
@bcoe bcoe added the automerge Merge the pull request once unit tests and other checks pass. label Apr 28, 2021
bcoe
bcoe suggested changes Apr 28, 2021
View reviewed changes
Copy link
Copy Markdown

@bcoe bcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we actually want to take this breaking change?

@gcf-merge-on-green
Copy link
Copy Markdown
Contributor

gcf-merge-on-green Bot commented Apr 29, 2021

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Apr 29, 2021
@trusted-contributions-gcf trusted-contributions-gcf Bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 4, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 4, 2021
@trusted-contributions-gcf trusted-contributions-gcf Bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 7, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 7, 2021
@trusted-contributions-gcf trusted-contributions-gcf Bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 10, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 10, 2021
@trusted-contributions-gcf trusted-contributions-gcf Bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 11, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 11, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 21, 2021
@sofisl sofisl removed the automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit label May 21, 2021
@sofisl sofisl closed this May 21, 2021
@sofisl sofisl reopened this May 21, 2021
@trusted-contributions-gcf trusted-contributions-gcf Bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 21, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 21, 2021
@trusted-contributions-gcf trusted-contributions-gcf Bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 25, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 25, 2021
@trusted-contributions-gcf trusted-contributions-gcf Bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 25, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 25, 2021
@trusted-contributions-gcf trusted-contributions-gcf Bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 27, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 27, 2021
@sofisl sofisl removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jun 1, 2021
@sofisl
Copy link
Copy Markdown
Contributor

sofisl commented Jun 1, 2021

Confirmed with @ikuleshov this breaking change is necessary.

@sofisl sofisl requested a review from bcoe June 1, 2021 17:42
@sofisl sofisl merged commit 10310c4 into master Jun 1, 2021
@sofisl sofisl deleted the release-v3.0.0 branch June 1, 2021 19:39
@yoshi-automation
Copy link
Copy Markdown
Contributor

yoshi-automation commented Jun 1, 2021

Release is at https://github.com/googleapis/nodejs-analytics-admin/releases/tag/v3.0.0

@release-tool-publish-reporter
Copy link
Copy Markdown

release-tool-publish-reporter Bot commented Jun 1, 2021

The release build has started, the log can be viewed here. 🌻

@release-tool-publish-reporter
Copy link
Copy Markdown

release-tool-publish-reporter Bot commented Jun 1, 2021

🥚 You hatched a release! The release build finished successfully! 💜

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@yoshi-approver yoshi-approver Awaiting requested review from yoshi-approver

2 more reviewers

@bcoe bcoe bcoe approved these changes

@sofisl sofisl sofisl approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: analyticsadmin Issues related to the googleapis/nodejs-analytics-admin API. autorelease: published cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sofisl @yoshi-automation @bcoe @yoshi-approver @yoshi-kokoro