fix: add publicUrl to exclude promisifyAll#1339
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
@fernandolguevara Thank you for contribution. Just a couple of nits. |
| */ | ||
| promisifyAll(File, { | ||
| exclude: ['request', 'setEncryptionKey'], | ||
| exclude: ['request', 'setEncryptionKey', 'publicUrl'], |
There was a problem hiding this comment.
Please place 'publicUrl' in alphabetic order.
Also please add 'publicUrl' to the list to fix unit tests
Line 77 in 642a9df
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Codecov Report
@@ Coverage Diff @@
## master #1339 +/- ##
=======================================
Coverage 99.00% 99.00%
=======================================
Files 14 14
Lines 11804 11804
Branches 526 595 +69
=======================================
Hits 11687 11687
Misses 117 117
Continue to review full report at Codecov.
|
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
@fernandolguevara friendly bump. If you do not have time to implement the requested changes, let me know and I can take it over from here. However, please sign the CLA so this PR can be merged. Thanks for making these changes! |
|
@googlebot I signed it! |
Co-authored-by: Sameena Shaffeeullah <shaffeeullah@google.com>
Fixes #1344
I exclude "publicUrl" from the list of functions that will use promises