docs: omit mention of Python 2.7 in 'CONTRIBUTING.rst' #191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trusted-contributions-gcf
bot
added
kokoro:force-run
product-auto-label
bot
added
the
api: bigquery
google-cla
bot
added
the
cla: yes
gcf-owl-bot
bot
removed
the
owlbot:run
jimfulton
reviewed
Jun 18, 2021
parthea
force-pushed
the
owl-bot-update-lock-b6169fc6a5207b11800a7c002d0c5c2bc6d82697185ca12e666f44031468cfcd
branch
from
fcdf5e3 to
07e4ac6
Compare
trusted-contributions-gcf
bot
added
the
owlbot:run
yoshi-kokoro
removed
the
kokoro:force-run
parthea
previously approved these changes
Jun 18, 2021
parthea
added
the
automerge
gcf-owl-bot
bot
removed
the
owlbot:run
parthea
added
do not merge
Contributor
|
Blocked by googleapis/synthtool#1132 |
parthea
changed the title
trusted-contributions-gcf
bot
added
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
parthea
added
owlbot:run
trusted-contributions-gcf
bot
added
the
kokoro:force-run
gcf-owl-bot
bot
removed
the
owlbot:run
yoshi-kokoro
removed
the
kokoro:force-run
1 task
Contributor
|
@jimfulton PTAL |
parthea
removed
the
do not merge
jimfulton
reviewed
Jun 22, 2021
Contributor
jimfulton
left a comment
jimfulton
left a comment
There was a problem hiding this comment.
I don't know what all the config file changes do :)
But wrt CONTRIBUTING.rst, I suggested some simplification that are more user friendly and version independent.
Comment on lines
+72
to
+75
| $ nox -s unit-3.6 | ||
| $ nox -s unit-3.7 | ||
| $ nox -s unit-3.8 | ||
| $ ... | ||
| $ nox -s unit-3.9 |
Contributor
There was a problem hiding this comment.
This should be simplified to:
$ nox -s unit
Comment on lines
148
to
+149
| $ nox -s system-3.8 | ||
| $ nox -s system-2.7 | ||
| $ nox -s system-3.9 |
Contributor
There was a problem hiding this comment.
This should be simplified to:
nox -s system
Contributor
|
Blocked by googleapis/synthtool#1135 |
Contributor
|
Added @tswast as reviewer for the kokoro changes. |
Contributor
|
Thanks for reviewing, @jimfulton ! I'll request another review once the templates are ready. |
gcf-merge-on-green bot
pushed a commit
to googleapis/synthtool
that referenced
this pull request
Jun 25, 2021
This is a follow up to PR #1132 based on feedback from googleapis/python-bigquery-sqlalchemy#191 to simplify the steps to run `nox` in [CONTRIBUTING.rst](https://github.com/googleapis/synthtool/blob/master/synthtool/gcp/templates/python_library/CONTRIBUTING.rst).
Contributor
|
Superseded by #195 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Source-Link: googleapis/synthtool@b91f129
Post-Processor: gcr.io/repo-automation-bots/owlbot-python:latest@sha256:b6169fc6a5207b11800a7c002d0c5c2bc6d82697185ca12e666f44031468cfcd
This PR also contains the following maintenance updates:
chore: add kokoro 3.9 config templates
chore: update precommit hook pre-commit/pre-commit-hooks to v4
chore(python): remove hardcoded versions in CONTRIBUTING.rst