-
Notifications
You must be signed in to change notification settings - Fork 139
docs: omit mention of Python 2.7 in 'CONTRIBUTING.rst' #191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
gcf-owl-bot
wants to merge
3
commits into
master
from
owl-bot-update-lock-b6169fc6a5207b11800a7c002d0c5c2bc6d82697185ca12e666f44031468cfcd
Closed
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| docker: | ||
| image: gcr.io/repo-automation-bots/owlbot-python:latest | ||
| digest: sha256:58c7342b0bccf85028100adaa3d856cb4a871c22ca9c01960d996e66c40548ce | ||
| digest: sha256:b6c55c48761d2ee099a68c94452125cbe02ac746d0497a424dc77751f0d11278 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| # Format: //devtools/kokoro/config/proto/build.proto | ||
|
|
||
| # Build logs will be here | ||
| action { | ||
| define_artifacts { | ||
| regex: "**/*sponge_log.xml" | ||
| } | ||
| } | ||
|
|
||
| # Specify which tests to run | ||
| env_vars: { | ||
| key: "RUN_TESTS_SESSION" | ||
| value: "py-3.9" | ||
| } | ||
|
|
||
| # Declare build specific Cloud project. | ||
| env_vars: { | ||
| key: "BUILD_SPECIFIC_GCLOUD_PROJECT" | ||
| value: "python-docs-samples-tests-py39" | ||
| } | ||
|
|
||
| env_vars: { | ||
| key: "TRAMPOLINE_BUILD_FILE" | ||
| value: "github/python-bigquery-sqlalchemy/.kokoro/test-samples.sh" | ||
| } | ||
|
|
||
| # Configure the docker image for kokoro-trampoline. | ||
| env_vars: { | ||
| key: "TRAMPOLINE_IMAGE" | ||
| value: "gcr.io/cloud-devrel-kokoro-resources/python-samples-testing-docker" | ||
| } | ||
|
|
||
| # Download secrets for samples | ||
| gfile_resources: "/bigstore/cloud-devrel-kokoro-resources/python-docs-samples" | ||
|
|
||
| # Download trampoline resources. | ||
| gfile_resources: "/bigstore/cloud-devrel-kokoro-resources/trampoline" | ||
|
|
||
| # Use the trampoline script to run in docker. | ||
| build_file: "python-bigquery-sqlalchemy/.kokoro/trampoline.sh" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| # Format: //devtools/kokoro/config/proto/build.proto | ||
|
|
||
| env_vars: { | ||
| key: "INSTALL_LIBRARY_FROM_SOURCE" | ||
| value: "True" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| # Format: //devtools/kokoro/config/proto/build.proto | ||
|
|
||
| env_vars: { | ||
| key: "INSTALL_LIBRARY_FROM_SOURCE" | ||
| value: "True" | ||
| } | ||
|
|
||
| env_vars: { | ||
| key: "TRAMPOLINE_BUILD_FILE" | ||
| value: "github/python-pubsub/.kokoro/test-samples-against-head.sh" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| # Format: //devtools/kokoro/config/proto/build.proto | ||
|
|
||
| env_vars: { | ||
| key: "INSTALL_LIBRARY_FROM_SOURCE" | ||
| value: "False" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| # Format: //devtools/kokoro/config/proto/build.proto | ||
|
|
||
| env_vars: { | ||
| key: "INSTALL_LIBRARY_FROM_SOURCE" | ||
| value: "True" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -69,14 +69,16 @@ We use `nox <https://nox.readthedocs.io/en/latest/>`__ to instrument our tests. | |
|
|
||
| - To test your changes, run unit tests with ``nox``:: | ||
|
|
||
| $ nox -s unit-2.7 | ||
| $ nox -s unit-3.6 | ||
| $ nox -s unit-3.7 | ||
| $ nox -s unit-3.8 | ||
| $ ... | ||
| $ nox -s unit-3.9 | ||
|
|
||
| - Args to pytest can be passed through the nox command separated by a `--`. For | ||
| example, to run a single test:: | ||
|
|
||
| $ nox -s unit-3.8 -- -k <name of test> | ||
| $ nox -s unit-3.9 -- -k <name of test> | ||
|
|
||
|
|
||
| .. note:: | ||
|
|
||
|
|
@@ -144,17 +146,16 @@ Running System Tests | |
|
|
||
| # Run all system tests | ||
| $ nox -s system-3.8 | ||
| $ nox -s system-2.7 | ||
| $ nox -s system-3.9 | ||
|
Comment on lines
148
to
+149
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This should be simplified to: |
||
|
|
||
| # Run a single system test | ||
| $ nox -s system-3.8 -- -k <name of test> | ||
| $ nox -s system-3.9 -- -k <name of test> | ||
|
|
||
|
|
||
| .. note:: | ||
|
|
||
| System tests are only configured to run under Python 2.7 and | ||
| Python 3.8. For expediency, we do not run them in older versions | ||
| of Python 3. | ||
| System tests are only configured to run under Python 3.8 and 3.9. | ||
| For expediency, we do not run them in older versions of Python 3. | ||
|
|
||
| This alone will not run the tests. You'll need to change some local | ||
| auth settings and change some configuration in your project to | ||
|
|
@@ -218,8 +219,8 @@ Supported versions can be found in our ``noxfile.py`` `config`_. | |
| .. _config: https://github.com/googleapis/python-bigquery-sqlalchemy/blob/master/noxfile.py | ||
|
|
||
|
|
||
| We also explicitly decided to support Python 3 beginning with version | ||
| 3.6. Reasons for this include: | ||
| We also explicitly decided to support Python 3 beginning with version 3.6. | ||
| Reasons for this include: | ||
|
|
||
| - Encouraging use of newest versions of Python 3 | ||
| - Taking the lead of `prominent`_ open-source `projects`_ | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be simplified to: