fix(retry): retry on httpx.TimeoutException with HttpRetryOptions#2345
Merged
yinghsienwu merged 3 commits intogoogleapis:mainfrom Apr 27, 2026
Merged
fix(retry): retry on httpx.TimeoutException with HttpRetryOptions#2345yinghsienwu merged 3 commits intogoogleapis:mainfrom
yinghsienwu merged 3 commits intogoogleapis:mainfrom
Conversation
The retry predicate in `retry_args` only matched `errors.APIError` subclasses, so lower-level httpx transport exceptions (`httpx.TimeoutException`, `httpx.ConnectError`, and their subclasses such as `ReadTimeout` / `ConnectTimeout`) were silently dropped and never retried, even when `HttpRetryOptions` was explicitly configured. Long-running LLM inference calls regularly hit transient transport errors from load balancers, NAT gateways, and idle TCP timeouts. Vertex AI's retry strategy guidance lists socket timeouts and TCP disconnects as retryable, so honoring those here matches user expectations. Fixes googleapis#2337.
yinghsienwu
approved these changes
Apr 27, 2026
This was referenced Apr 27, 2026
copybara-service Bot
pushed a commit
that referenced
this pull request
Apr 27, 2026
-- b5c7090 by Mukunda Rao Katta <mukunda.vjcs6@gmail.com>: fix(retry): retry on httpx.TimeoutException with HttpRetryOptions The retry predicate in `retry_args` only matched `errors.APIError` subclasses, so lower-level httpx transport exceptions (`httpx.TimeoutException`, `httpx.ConnectError`, and their subclasses such as `ReadTimeout` / `ConnectTimeout`) were silently dropped and never retried, even when `HttpRetryOptions` was explicitly configured. Long-running LLM inference calls regularly hit transient transport errors from load balancers, NAT gateways, and idle TCP timeouts. Vertex AI's retry strategy guidance lists socket timeouts and TCP disconnects as retryable, so honoring those here matches user expectations. Fixes #2337. FUTURE_COPYBARA_INTEGRATE_REVIEW=#2345 from MukundaKatta:fix/retry-httpx-timeout 9b2d886 PiperOrigin-RevId: 906620787
This was referenced Apr 28, 2026
copybara-service Bot
pushed a commit
that referenced
this pull request
Apr 28, 2026
`import google.genai` no longer eagerly imports `mcp`. The public symbols `McpClientSession`, `McpCallToolResult`, and `mcp_types` resolve lazily on first attribute access (PEP 562 `__getattr__`). FUTURE_COPYBARA_INTEGRATE_REVIEW=#2345 from MukundaKatta:fix/retry-httpx-timeout 9b2d886 PiperOrigin-RevId: 905291907
This was referenced Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2337.
httpx.TimeoutExceptionwas not in the retryable-exception tuple, so requests timed out and surfaced the error even whenHttpRetryOptionswas configured. Added the exception (along withhttpx.ConnectError) so transient transport failures retry like other recoverable errors.Test added in
google/genai/tests/client/test_retries.py::test_retry_args_retries_httpx_transport_errors.