Copybara import of the project:#2360
Open
copybara-service[bot] wants to merge 1 commit intomainfrom
Open
Conversation
-- b5c7090 by Mukunda Rao Katta <mukunda.vjcs6@gmail.com>: fix(retry): retry on httpx.TimeoutException with HttpRetryOptions The retry predicate in `retry_args` only matched `errors.APIError` subclasses, so lower-level httpx transport exceptions (`httpx.TimeoutException`, `httpx.ConnectError`, and their subclasses such as `ReadTimeout` / `ConnectTimeout`) were silently dropped and never retried, even when `HttpRetryOptions` was explicitly configured. Long-running LLM inference calls regularly hit transient transport errors from load balancers, NAT gateways, and idle TCP timeouts. Vertex AI's retry strategy guidance lists socket timeouts and TCP disconnects as retryable, so honoring those here matches user expectations. Fixes #2337. FUTURE_COPYBARA_INTEGRATE_REVIEW=#2345 from MukundaKatta:fix/retry-httpx-timeout 9b2d886 PiperOrigin-RevId: 906620787
copybara-service
Bot
force-pushed
the
copybara/906620787
branch
from
35d5434 to
d113ed4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copybara import of the project:
--
b5c7090 by Mukunda Rao Katta mukunda.vjcs6@gmail.com:
fix(retry): retry on httpx.TimeoutException with HttpRetryOptions
The retry predicate in
retry_argsonly matchederrors.APIErrorsubclasses,so lower-level httpx transport exceptions (
httpx.TimeoutException,httpx.ConnectError, and their subclasses such asReadTimeout/ConnectTimeout) were silently dropped and never retried, even whenHttpRetryOptionswas explicitly configured.Long-running LLM inference calls regularly hit transient transport errors
from load balancers, NAT gateways, and idle TCP timeouts. Vertex AI's
retry strategy guidance lists socket timeouts and TCP disconnects as
retryable, so honoring those here matches user expectations.
Fixes #2337.
FUTURE_COPYBARA_INTEGRATE_REVIEW=#2345 from MukundaKatta:fix/retry-httpx-timeout 9b2d886