fix(tombstone-library): generate Rakefile for release builds - #453
Open
torreypayne wants to merge 3 commits into
Open
fix(tombstone-library): generate Rakefile for release builds#453torreypayne wants to merge 3 commits into
torreypayne wants to merge 3 commits into
Conversation
… in gemspec template" This reverts commit efac5a5.
torreypayne
changed the title
aandreassa
approved these changes
Aug 11, 2026
| @@ -0,0 +1,18 @@ | |||
| # frozen_string_literal: true | |||
|
|
|||
| # Copyright <%= cur_year %> Google LLC | |||
Contributor
There was a problem hiding this comment.
cur_year. Does this work? Otherwise, LGTM! I will ping you with a suggestion for testing.
Contributor
There was a problem hiding this comment.
Maybe something like this can work: https://github.com/googleapis/gapic-generator-ruby/blob/cf7b51a224feacfbe2a187cad412824fdb7a48d2/gapic-generator-ads/templates/ads/shared/_license.text.erb#L1
No need to spend tons of time testing this btw! It is pretty isolated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When tombstoning a library using
toys tombstone-library, all existing files in the gem directory are purged and replaced with a minimal tombstone skeleton (README.md,LICENSE.md,.gemspec,.yardopts,version.rb). However, the tool previously omitted aRakefile, leading to errors when releasing the tombstoned version of the package.Context & Failure Mode
During the recent tombstoning of the
stackdrivergem (googleapis/google-cloud-ruby#34614), automated release packaging viarelease-please(triggered on tagstackdriver/v1.0.0) failed in the release CI/CD workflow with:Because release packaging automation relies on executing
bundle exec rake buildto compile the.gemartifact prior to RubyGems publication, the absence of aRakefileinvokingbundler/gem_tasksaborted the release pipeline. We had to manually push a follow-up patch PR (googleapis/google-cloud-ruby#34652) to restore a minimalRakefile, which caused release tag collisions and required manual changelog fixes.Changes
toys/tombstone-library/.data/rakefile-template.erbcontaining the standard license header,require "bundler/setup", andrequire "bundler/gem_tasks".generate_filesintoys/tombstone-library/.toys.rbto generateRakefileautomatically when tombstoning any library.Downstream Reference
Tested and validated downstream against the Apigee Registry tombstone draft PR: googleapis/google-cloud-ruby#36233.