Deploy official Istio dashboards in update-istio.sh#734
Merged
Conversation
awhdesmond
changed the title
awhdesmond
changed the title
Tobias-Pe
approved these changes
Jun 17, 2026
|
|
||
| for dashboard in "${DASHBOARDS[@]}"; do | ||
| json_file="${tmpdir}/${dashboard}" | ||
| curl -fsSL "https://raw.githubusercontent.com/istio/istio/${VERSION}/manifests/addons/dashboards/${dashboard}" -o "${json_file}" |
Contributor
There was a problem hiding this comment.
[CORRECTNESS, PERFORMANCE] Please consider the following updates to improve the dashboard downloads:
- Verify the exit status of the
curlcommand to ensure the script fails early if a download fails, preventing invalid YAML generation. - Optimize the download speed by running them in parallel (using background jobs with
&andwait) or using a batchedcurlinvocation to avoid sequential network round-trips.
🤖 AI Reviewer (Jetski) | Traces: correctness: go/traj/bb1b5fdf-6a81-49b3-a3b2-5c871244056f, performance: go/traj/233135f6-adce-4d81-ba66-9607b5ea9999
Contributor
There was a problem hiding this comment.
WRT optimiation maybe just a nit or even ignorable imo but the exit code could be relevant
Contributor
Author
There was a problem hiding this comment.
Updated script to used batched curl and exit on download failure.
awhdesmond
force-pushed
the
awhdesmond/istio-dashboards
branch
from
4b61e53 to
9fdf785
Compare
ensonic
reviewed
Jun 18, 2026
| ) | ||
|
|
||
| dashboard_yaml="${tmpdir}/dashboards.yaml" | ||
| true > "${dashboard_yaml}" |
Contributor
There was a problem hiding this comment.
Since this is a tempdir, we can probably just use touch "${dashboard_yaml}" as there is no need to reset the file.
awhdesmond
force-pushed
the
awhdesmond/istio-dashboards
branch
from
038c37b to
b30effa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deploy official Istio dashboardsbased on the version used in
update-istio.sh. I think we can start with these and add custom dashboards when required.Grafana version required: "pluginVersion": "v11.0.0"