Update the defaults for the relay.#759
Merged
Merged
Conversation
csieber
approved these changes
Jun 26, 2026
hheibel
reviewed
Jun 26, 2026
hheibel
left a comment
hheibel
left a comment
Contributor
There was a problem hiding this comment.
Thanks Stefan. This looks generally good. Do we have a way to test these changes? Will this happen via existing unit or post-submit tests or will this happen by exercising the relay on intrinsic-dev or similar projects?
Contributor
Author
The tests are both unit and integration tested. |
hheibel
approved these changes
Jun 26, 2026
Add comment to explain the chosen values. Replace the TODO in the relay client with an explanation why we need the chunking.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add comment to explain the chosen values. Replace the TODO in the relay client with an explanation why we need the chunking.