Add more tests to drive up coverage.#766
Merged
Merged
Conversation
ensonic
force-pushed
the
ensonic/tests
branch
3 times, most recently
from
6078330 to
01a318a
Compare
Contributor
Author
|
@therjak Sorry for the large PR. I am not entirely happy with the controller_tests.go yet. I'll send a followup to split the approllout/validator like we do for chart assignments. |
therjak
requested changes
Jun 30, 2026
Contributor
Author
|
100 thanks for the in-depth review. |
koonpeng
reviewed
Jul 1, 2026
therjak
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main goal is to get more peace of mind when accepting dependabot changes.