Add COLR test fonts#674
Merged
Merged
Conversation
dfrg
approved these changes
Oct 25, 2023
Member
dfrg
left a comment
dfrg
left a comment
There was a problem hiding this comment.
Glad to see these arrive and looking forward to color support!
One nit: our policy is to check in the associated ttx files as well in the ttx directory. Once that’s done, this lgtm!
Use COLRv0/v1 test fonts from [1] to aid in the work of developing a COLRv1/COLRv0 painter callback interface, as outlined in [2]. [1] https://github.com/googlefonts/color-fonts [2] googlefonts/oxidize#48 (comment)
drott
force-pushed
the
addColrV1TestFonts
branch
from
5f96292 to
6a3e29d
Compare
Contributor
Author
|
Thanks, for the review, TTX'es added, merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use COLRv0/v1 test fonts from [1] to aid in the work of developing a COLRv1/COLRv0 painter callback interface, as outlined in [2].
[1] https://github.com/googlefonts/color-fonts
[2] googlefonts/oxidize#48 (comment)