Skip to content

Respectful code cleanup No.2#2109

Merged
roberthbailey merged 1 commit intoagones-dev:mainfrom
markmandel:cleanup/respectful-no2
May 26, 2021
Merged

Respectful code cleanup No.2#2109
roberthbailey merged 1 commit intoagones-dev:mainfrom
markmandel:cleanup/respectful-no2

Conversation

@markmandel
Copy link
Collaborator

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

Switching out some more verbiage to be more inclusive.

Which issue(s) this PR fixes:

Special notes for your reviewer:

N/A

Switching out some more verbiage to be more inclusive.
@markmandel markmandel added the kind/cleanup Refactoring code, fixing up documentation, etc label May 26, 2021
@google-cla google-cla bot added the cla: yes label May 26, 2021
@markmandel markmandel requested review from roberthbailey and removed request for cyriltovena and dzlier-gcp May 26, 2021 00:08
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: e0f6da28-0ddc-4b7b-b2ed-d01989b3019a

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2109/head:pr_2109 && git checkout pr_2109
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.15.0-a27c9df

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roberthbailey roberthbailey merged commit 4bb2cc0 into agones-dev:main May 26, 2021
@markmandel markmandel deleted the cleanup/respectful-no2 branch May 26, 2021 16:53
@markmandel markmandel added this to the 1.15.0 milestone May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved cla: yes kind/cleanup Refactoring code, fixing up documentation, etc size/S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants