Skip to content

Rename metapatch var in applyAllocationToGameServer#2198

Merged
roberthbailey merged 1 commit intoagones-dev:mainfrom
markmandel:refactor/rename-args
Jul 28, 2021
Merged

Rename metapatch var in applyAllocationToGameServer#2198
roberthbailey merged 1 commit intoagones-dev:mainfrom
markmandel:refactor/rename-args

Conversation

@markmandel
Copy link
Collaborator

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

Minor fix from a PR comment that I had in the backlog but hadn't submitted yet.

Which issue(s) this PR fixes:

Fix for #2148 (comment)

Special notes for your reviewer:

N/A

Minor fix from a PR comment that I had in the backlog but hadn't
submitted yet.

Fix for agones-dev#2148 (comment)
@markmandel markmandel added the kind/cleanup Refactoring code, fixing up documentation, etc label Jul 27, 2021
@markmandel markmandel requested a review from roberthbailey July 27, 2021 22:30
@google-cla google-cla bot added the cla: yes label Jul 27, 2021
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: d02a6c2d-ef39-4c88-8183-66d9484d53f3

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 72568eb9-ca28-49f6-be3d-7c957100d7d7

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 3ffeb5d5-afc4-4842-b23e-8ec7c39112dc

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 3302c982-1a52-4dc8-b7fd-a0c0e2a5a098

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2198/head:pr_2198 && git checkout pr_2198
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.17.0-2864e19

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roberthbailey roberthbailey merged commit 7db59fc into agones-dev:main Jul 28, 2021
@markmandel markmandel deleted the refactor/rename-args branch July 28, 2021 18:30
@roberthbailey roberthbailey added this to the 1.17.0 milestone Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved cla: yes kind/cleanup Refactoring code, fixing up documentation, etc size/S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants