Skip to content

Conversation

@allieychen
Copy link
Contributor

In BQ to VCF, when inferring the meta-information from BigQuery schema, the annotation header is not added to the INFO. This PR reconstructs the annotation description and adds it to the meta-information.

Tested: manually tested BQ to VCF and loaded it back to BQ.
Issues: 382

This reverts commit 9439939.
@coveralls
Copy link

coveralls commented Oct 18, 2018

Pull Request Test Coverage Report for Build 1395

  • 18 of 18 (100.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 87.671%

Totals Coverage Status
Change from base Build 1394: 0.04%
Covered Lines: 6279
Relevant Lines: 7162

💛 - Coveralls

Copy link
Contributor

@arostamianfar arostamianfar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Very cool!

@allieychen allieychen merged commit f77b4cd into googlegenomics:master Oct 18, 2018
@allieychen allieychen deleted the annotation branch October 18, 2018 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants