Update deploy_and_run_tests with httplib2 update #454
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1634
💛 - Coveralls |
Contributor
|
Please checkout a new branch from the master, so that the commits for other issues won't be mixed together :) |
tneymanov
force-pushed
the
deploy_httplib2
branch
from
5bbbdad to
7d10f73
Compare
kemp-google
reviewed
Mar 14, 2019
| # Due to the dependency issue, we have to manually upgrade httplib2 in order to | ||
| # circumvent the CERTIFICATE_VERIFY_FAILED error. For more info, visit | ||
| # https://github.com/googlegenomics/gcp-variant-transforms/issues/453. | ||
| pip install --upgrade httplib2 |
There was a problem hiding this comment.
# Force an upgrade to avoid SSL certificate verification errors (issue #453).
I think that will (a) be sufficient and (b) autolink to the issue?
tneymanov
force-pushed
the
deploy_httplib2
branch
from
7d10f73 to
4298fdc
Compare
kemp-google
approved these changes
Mar 14, 2019
tneymanov
force-pushed
the
deploy_httplib2
branch
from
4298fdc to
2f0bad9
Compare
tneymanov
force-pushed
the
deploy_httplib2
branch
from
2f0bad9 to
8dc98ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update deploy_and_run_tests.sh to upgrade httplib2 to newer version.
Workaround for #453