Skip to content

Update deploy_and_run_tests with httplib2 update #454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 14, 2019
Merged

Update deploy_and_run_tests with httplib2 update #454

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8f9247a
Update deploy_and_run_tests.sh to upgrade httplib2 to newer version.
tneymanov Mar 11, 2019
8dc98ea
Modify the comment as per review request.
tneymanov Mar 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions deploy_and_run_tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,6 +227,9 @@ if [[ -n "${run_unit_tests}" ]]; then
fi
pip install --upgrade .[int_test]

# Force an upgrade to avoid SSL certificate verification errors (issue #453).
pip install --upgrade httplib2
Copy link

@kemp-google kemp-google Mar 14, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

# Force an upgrade to avoid SSL certificate verification errors (issue #453).

I think that will (a) be sufficient and (b) autolink to the issue?

Copy link
Collaborator Author

@tneymanov tneymanov Mar 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.


color_print "Running integration tests against ${full_image_name}" "${GREEN}"
python gcp_variant_transforms/testing/integration/run_vcf_to_bq_tests.py \
--project "${project}" \
Expand Down