Fix #308 - Add null check for removing item from uninitialized QuadTree#314
Merged
Conversation
|
Awesome, can't wait for the merge. |
Collaborator
Author
|
@stephenmcd a friendly reminder to PTAL, when you have a moment. I was able to repro the bug within the unit test and then fix to make it pass, so it's a pretty straightforward fix. |
Contributor
|
Thanks for the reminder! Looks good. |
|
Thanks all |
|
Is that possible this bug is introduced again? I still have problem with that, please take a look #348 (comment) |
Collaborator
Author
|
@natansalda At a glance it looks like this is a different issue - I'll reply on your other comment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was able to repro #308 NPE by trying to remove an item before any item was inserted - I added a test case that repro's this NPE at the beginning of
PointQuadTreeTest.testMultiplePoints():Adding a null check in
PointQuadTree.remove()fixes this.