Add more AddressComponentTypes#633
Merged
jpoehnelt merged 1 commit intogooglemaps:masterfrom Dec 10, 2019
Merged
Conversation
googlebot
added
the
cla: yes
petedmarsh
force-pushed
the
add-more-address-component-types
branch
from
7afa508 to
df6f6e6
Compare
Contributor
|
@petedmarsh if you fix the failing test, I'll merge this and deal with conflicts at a later point in #629 |
petedmarsh
force-pushed
the
add-more-address-component-types
branch
from
df6f6e6 to
a72d433
Compare
Contributor
Author
|
@jpoehnelt fixed, thanks! |
jpoehnelt
approved these changes
Dec 10, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm using v0.10.0 and I've seen occurrences of the following AddressComponentTypes. This will conflict with #629 unfortunately, I can fix any conflicts if that is merged first.