Skip to content

documentation problem#642

Merged
jpoehnelt merged 5 commits intogooglemaps:masterfrom
ironblaster:master
Jan 7, 2020
Merged

documentation problem#642
jpoehnelt merged 5 commits intogooglemaps:masterfrom
ironblaster:master

Conversation

@ironblaster
Copy link
Copy Markdown
Contributor

in the readme file, the call of the shutdown () method is not specified at the end of a request.

this is a problem because after n requests java creates multiple threads not closed
and in the case of tomcat the instance goes into error

@googlebot
Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Jan 2, 2020
@ironblaster
Copy link
Copy Markdown
Contributor Author

@googlebot I signed it!

@googlebot
Copy link
Copy Markdown

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Jan 2, 2020
@coveralls
Copy link
Copy Markdown

coveralls commented Jan 2, 2020

Coverage Status

Coverage remained the same at 74.002% when pulling 9ee6685 on ironblaster:master into 70ea97b on googlemaps:master.

@ironblaster ironblaster changed the title documentation problem #641 documentation problem Jan 2, 2020
Comment thread README.md Outdated
Co-Authored-By: Justin Poehnelt <jpoehnelt@google.com>
@ironblaster ironblaster requested a review from jpoehnelt January 3, 2020 09:45
@ironblaster ironblaster closed this Jan 7, 2020
@ironblaster ironblaster reopened this Jan 7, 2020
@ironblaster
Copy link
Copy Markdown
Contributor Author

thanks, do I have to do more to confirm?

@jpoehnelt jpoehnelt merged commit 8a44e9d into googlemaps:master Jan 7, 2020
@jpoehnelt jpoehnelt mentioned this pull request Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants