Skip to content

fix: Escape sonatype password#717

Merged
jpoehnelt merged 1 commit intomasterfrom
chris/fix_publish
Feb 2, 2021
Merged

fix: Escape sonatype password#717
jpoehnelt merged 1 commit intomasterfrom
chris/fix_publish

Conversation

@arriolac
Copy link
Copy Markdown
Contributor

@arriolac arriolac commented Feb 2, 2021

Publish workflow was still failing after #716. Escaping the password however fixed #695.

After these changes, I verified that the publish workflow works now. See: https://github.com/googlemaps/google-maps-services-java/actions/runs/529636053

@arriolac arriolac requested a review from jpoehnelt February 2, 2021 03:43
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Feb 2, 2021
@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #717 (15a9925) into master (c420e34) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #717   +/-   ##
=========================================
  Coverage     69.12%   69.12%           
  Complexity      531      531           
=========================================
  Files           129      129           
  Lines          2892     2892           
  Branches        283      283           
=========================================
  Hits           1999     1999           
  Misses          741      741           
  Partials        152      152           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c420e34...15a9925. Read the comment docs.

@googlemaps googlemaps deleted a comment from giakhangdouble Feb 2, 2021
@googlemaps googlemaps deleted a comment from giakhangdouble Feb 2, 2021
@googlemaps googlemaps deleted a comment from giakhangdouble Feb 2, 2021
@jpoehnelt jpoehnelt merged commit f962390 into master Feb 2, 2021
@jpoehnelt jpoehnelt deleted the chris/fix_publish branch February 2, 2021 16:00
googlemaps-bot pushed a commit that referenced this pull request Feb 2, 2021
## [0.16.2](v0.16.1...v0.16.2) (2021-02-02)

### Bug Fixes

* Escape password. ([#717](#717)) ([f962390](f962390))
@googlemaps-bot
Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 0.16.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement. released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix GitHub publish workflow

4 participants