-
Notifications
You must be signed in to change notification settings - Fork 2k
build: pnpm and enable JSDoc type checking for .gs files via TSC
#580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…e JSDoc type checking for `.gs` files via TSC
Summary of ChangesHello @jpoehnelt, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces significant improvements to the project's development workflow and code quality. It modernizes the package management system by adopting pnpm, provides a detailed guide for Apps Script development, and integrates static type checking for Apps Script files using JSDoc and TypeScript. These changes aim to make development more efficient, consistent, and less prone to errors. Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces pnpm for package management and a new TypeScript-based script for type-checking .gs files using JSDoc, which is a great step towards improving code quality and developer experience. The PR also includes comprehensive documentation for Apps Script development and the new type-checking process.
My review focuses on the new check-gs.ts script. I've found a couple of critical bugs in the file copying and error path rewriting logic that will prevent the script from working as intended. I've also pointed out a type-safety issue in the error handling. Addressing these points will ensure the new type-checking tool is robust and reliable.
…and simplify directory creation.
.gs files via TSC.gs files via TSC
No description provided.