BREAKING CHANGE: Remove MCP server mode#275
Conversation
🦋 Changeset detectedLatest commit: 0245fb2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
googleworkspace-bot
added
area: mcp
area: docs
area: core
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request implements a breaking change by completely removing the Model Context Protocol (MCP) server mode. This change streamlines the application by eliminating a feature that is no longer supported or desired, simplifying the codebase and documentation by removing all associated components and references. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes the Model Context Protocol (MCP) server functionality. The changes include deleting the mcp_server.rs file, removing the corresponding module and command handling from main.rs, and updating the documentation in README.md and AGENTS.md to reflect this removal. The changes are consistent and effectively remove the feature from the codebase. The removal appears to be complete with no dangling references found in the provided files.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request removes the MCP server mode, which is a significant breaking change. The changes are clean and effectively remove the mcp command and its implementation across the codebase, including documentation updates. My main feedback is regarding the versioning of this breaking change in the changeset file to ensure it follows semantic versioning principles.
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| "@googleworkspace/cli": minor | |||
There was a problem hiding this comment.
The pull request title correctly identifies this as a BREAKING CHANGE due to the removal of the mcp command. However, the changeset is marked as minor. According to semantic versioning, breaking changes should trigger a major version update. This is important to signal to users that an update will break their existing workflows if they depend on the removed feature.
| "@googleworkspace/cli": minor | |
| "@googleworkspace/cli": major |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #275 +/- ##
==========================================
+ Coverage 57.95% 59.09% +1.13%
==========================================
Files 37 36 -1
Lines 13803 12953 -850
==========================================
- Hits 7999 7654 -345
+ Misses 5804 5299 -505 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
v0.8.0+ removes the stdio MCP transport we rely on for proxying gws commands (see googleworkspace/cli#275). Pinned in Dockerfile and blocked via Renovate allowedVersions until we have an alternative. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
## [1.9.1](v1.9.0...v1.9.1) (2026-03-06) ### Bug Fixes * **gws:** pin @googleworkspace/cli to 0.7.0, block Renovate upgrades ([560eea3](560eea3)), closes [googleworkspace/cli#275](googleworkspace/cli#275)
|
@sqrrrl Hi there, I started using the cli today and added the MCP to my workflow - so useful! So I was quite shocked to see this PR - already merged no less. Could you give some insights how you/the team thinks about the future of the MCP? PS: I realize I match this classic xkcd and I apologize. |
This reverts commit dd3fc90.
4 participants
Description
Please include a summary of the change and which issue is fixed. If adding a new feature or command, please include the output of running it with
--dry-runto prove the JSON request body matches the Discovery Document schema.Dry Run Output:
// Paste --dry-run output here if applicableChecklist:
AGENTS.mdguidelines (no generatedgoogle-*crates).cargo fmt --allto format the code perfectly.cargo clippy -- -D warningsand resolved all warnings.pnpx changeset) to document my changes.