fix(docs): correct broken flag names in recipes#451
fix(docs): correct broken flag names in recipes#451jpoehnelt merged 1 commit intogoogleworkspace:mainfrom
Conversation
Three categories of broken flags in registry/recipes.yaml: 1. --spreadsheet-id → --spreadsheet (10 occurrences) The actual flag in sheets.rs is --spreadsheet, not --spreadsheet-id. Every sheet recipe using this flag would fail. 2. --attendees → --attendee (repeated flag, 4 occurrences) The calendar +insert helper uses --attendee with ArgAction::Append for multiple attendees, not a comma-separated --attendees flag. 3. --duration → --end (4 occurrences) The calendar +insert helper has no --duration flag. It requires an explicit --end time in ISO 8601 format.
🦋 Changeset detectedLatest commit: ff1ef1c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses critical issues in the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly fixes several broken flag names in the CLI recipes, which is a crucial correction for usability. The changes properly replace --spreadsheet-id with --spreadsheet, handle --attendees as an appendable flag, and replace the non-existent --duration flag with --end. My review identifies a potential correctness issue in the updated calendar event creation commands. The timestamps for start and end times are missing timezone information, which can lead to ambiguity and incorrect event creation. I've suggested adding UTC timezone specifiers for consistency and to ensure events are created at the correct time.
2 participants
Summary
Fix 18 broken flag references across
registry/recipes.yamlthat would cause recipe commands to fail:--spreadsheet-id--spreadsheet--attendees a,b--attendee a --attendee bArgAction::Append--duration 30--end <ISO8601>Impact
Any AI agent or user following these recipes verbatim would get
UnrecognizedArgerrors. Since recipes are auto-published as SKILL.md files consumed by AI agents, this directly affects agent reliability.Test plan
src/helpers/sheets.rsandsrc/helpers/calendar.rs--spreadsheet-id,--attendees, or--durationreferences