fix: warn to stderr when unknown --format value is provided (fixes #38)#49
Merged
fix: warn to stderr when unknown --format value is provided (fixes #38)#49
Conversation
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
🦋 Changeset detectedLatest commit: ee35e4a The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
578a5d7 to
ee35e4a
Compare
shigechika
pushed a commit
to shigechika/gws-cli
that referenced
this pull request
Mar 20, 2026
…n-format-warning fix: warn to stderr when unknown --format value is provided (fixes googleworkspace#38)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #38
Changes
OutputFormat::parse(s) -> Result<Self, String>which returnsErrfor unknown format stringsmain.rsto call the newparse()method and print a clear warning to stderr when an unknown format is supplied, then fall back to JSONfrom_stris retained as a convenience wrapper (silent fallback) for any internal callers