fix(ci): skip publish-skills on fork PRs#604
Conversation
|
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
googleworkspace-bot
added
the
cla: yes
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates documentation links in skills/gws-drive/SKILL.md, changing some relative URLs to absolute ones. However, one change incorrectly removes critical information regarding the use of files.export for Google Docs, Sheets, and Slides, which should be restored. Additionally, the changes in this pull request appear to be unrelated to its stated goal of fixing a CI workflow, leading to confusion about the PR's scope and making it difficult to review.
| - `get` — Gets a shared drive's metadata by ID. For more information, see [Manage shared drives](https://developers.google.com/workspace/drive/api/guides/manage-shareddrives). | ||
| - `hide` — Hides a shared drive from the default view. For more information, see [Manage shared drives](https://developers.google.com/workspace/drive/api/guides/manage-shareddrives). | ||
| - `list` — Lists the user's shared drives. This method accepts the `q` parameter, which is a search query combining one or more search terms. For more information, see the [Search for shared drives](/workspace/drive/api/guides/search-shareddrives) guide. | ||
| - `list` — Lists the user's shared drives. This method accepts the `q` parameter, which is a search query combining one or more search terms. For more information, see the [Search for shared drives](https://developers.google.com/workspace/drive/api/guides/search-shareddrives) guide. |
There was a problem hiding this comment.
The changes in this file seem unrelated to the pull request's stated goal of fixing a CI workflow (fix(ci): skip publish-skills on fork PRs). The PR description also details a CI change, but no workflow files are included in this pull request's patch. This discrepancy is confusing and makes the PR unreviewable in its current state.
Per repository guidelines, changes should be focused on the primary goal of a pull request to avoid scope creep. Please either:
- Move these documentation changes to a separate PR with a relevant title and description.
- Add the missing CI changes to this PR.
- Update the PR title and description to reflect the content of the changes.
References
- Avoid introducing changes that are outside the primary goal of a pull request to prevent scope creep.
| - `generateIds` — Generates a set of file IDs which can be provided in create or copy requests. For more information, see [Create and manage files](https://developers.google.com/workspace/drive/api/guides/create-file). | ||
| - `get` — Gets a file's metadata or content by ID. For more information, see [Search for files and folders](/workspace/drive/api/guides/search-files). If you provide the URL parameter `alt=media`, then the response includes the file contents in the response body. Downloading content with `alt=media` only works if the file is stored in Drive. To download Google Docs, Sheets, and Slides use [`files.export`](/workspace/drive/api/reference/rest/v3/files/export) instead. | ||
| - `list` — Lists the user's files. For more information, see [Search for files and folders](/workspace/drive/api/guides/search-files). This method accepts the `q` parameter, which is a search query combining one or more search terms. This method returns *all* files by default, including trashed files. If you don't want trashed files to appear in the list, use the `trashed=false` query parameter to remove trashed files from the results. | ||
| - `get` — Gets a file's metadata or content by ID. For more information, see [Search for files and folders](https://developers.google.com/workspace/drive/api/guides/search-files). If you provide the URL parameter `alt=media`, then the response includes the file contents in the response body. Downloading content with `alt=media` only works if the file is stored in Drive. |
There was a problem hiding this comment.
This change incorrectly removes crucial information. The get method with alt=media cannot be used to download Google Docs, Sheets, and Slides; files.export must be used instead. This information should be restored to avoid user confusion.
If you decide to keep these documentation changes in a PR, please restore this sentence and also update its link to be an absolute URL for consistency.
| - `get` — Gets a file's metadata or content by ID. For more information, see [Search for files and folders](https://developers.google.com/workspace/drive/api/guides/search-files). If you provide the URL parameter `alt=media`, then the response includes the file contents in the response body. Downloading content with `alt=media` only works if the file is stored in Drive. | |
| - `get` — Gets a file's metadata or content by ID. For more information, see [Search for files and folders](https://developers.google.com/workspace/drive/api/guides/search-files). If you provide the URL parameter `alt=media`, then the response includes the file contents in the response body. Downloading content with `alt=media` only works if the file is stored in Drive. To download Google Docs, Sheets, and Slides use [`files.export`](https://developers.google.com/workspace/drive/api/reference/rest/v3/files/export) instead. |
github-actions
Bot
added
the
gemini: reviewed
3 participants
Fork PRs don't have access to repository secrets (
CLAWHUB_TOKEN), causing the publish-skills workflow to always fail on external contributions.Adds the same fork guard pattern used by the smoketest job — skips the job entirely on fork PRs while preserving behavior for same-repo PRs (dry-run), pushes to main, scheduled runs, and manual dispatch.