fix: move data files into CLI crate for crates.io publishing#620
fix: move data files into CLI crate for crates.io publishing#620
Conversation
|
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical packaging issue for the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request refactors the project's directory structure by adjusting relative paths for include_str! macros in generate_skills.rs and modelarmor.rs. This change likely involves moving the registry and templates directories to a new location relative to the source files. There is no feedback to provide.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request updates relative paths for include_str! macros in generate_skills.rs and modelarmor.rs to correctly reference personas.yaml, recipes.yaml, and jailbreak.json files. Additionally, it removes the 'sections' resource from the gws chat command documentation in SKILL.md. There are no review comments to provide feedback on.
Moves
registry/andtemplates/intocrates/google-workspace-cli/socargo publishcan package them. Updates `include_str``` paths accordingly.Without this,
cargo publish --package google-workspace-clifails because files referenced via `include_str``` escape the crate directory and aren't included in the published tarball.Verified with
cargo publish --dry-run --package google-workspace-cli.