Skip to content

fix: move data files into CLI crate for crates.io publishing#620

Merged
jpoehnelt merged 2 commits intomainfrom
fix/cli-publish-paths
Mar 24, 2026
Merged

fix: move data files into CLI crate for crates.io publishing#620
jpoehnelt merged 2 commits intomainfrom
fix/cli-publish-paths

Conversation

@jpoehnelt
Copy link
Member

Moves registry/ and templates/ into crates/google-workspace-cli/ so cargo publish can package them. Updates `include_str``` paths accordingly.

Without this, cargo publish --package google-workspace-cli fails because files referenced via `include_str``` escape the crate directory and aren't included in the published tarball.

Verified with cargo publish --dry-run --package google-workspace-cli.

@changeset-bot
Copy link

changeset-bot bot commented Mar 24, 2026

⚠️ No Changeset found

Latest commit: 4f8b15a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@googleworkspace-bot googleworkspace-bot added area: skills area: core Core CLI parsing, commands, error handling, utilities cla: yes This human has signed the Contributor License Agreement. labels Mar 24, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical packaging issue for the google-workspace-cli crate, which previously failed to publish to crates.io due to include_str! macros referencing files outside its directory. By relocating these external data files into the crate's structure and updating the corresponding paths, the change ensures that all necessary assets are correctly bundled, enabling successful publication and distribution of the crate.

Highlights

  • File Relocation: Moved registry/ and templates/ directories, containing data files, into the crates/google-workspace-cli/ directory.
  • Path Updates: Updated include_str! macro paths in generate_skills.rs and modelarmor.rs to reflect the new locations of the data files.
  • Crates.io Publishing Fix: Resolved an issue preventing cargo publish from successfully packaging the google-workspace-cli crate by ensuring all referenced files are within the crate directory.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Generative AI Prohibited Use Policy, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the project's directory structure by adjusting relative paths for include_str! macros in generate_skills.rs and modelarmor.rs. This change likely involves moving the registry and templates directories to a new location relative to the source files. There is no feedback to provide.

@googleworkspace-bot
Copy link
Collaborator

/gemini review

@github-actions github-actions bot added the gemini: reviewed Gemini Code Assist has reviewed the latest changes label Mar 24, 2026
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates relative paths for include_str! macros in generate_skills.rs and modelarmor.rs to correctly reference personas.yaml, recipes.yaml, and jailbreak.json files. Additionally, it removes the 'sections' resource from the gws chat command documentation in SKILL.md. There are no review comments to provide feedback on.

@jpoehnelt jpoehnelt merged commit 19ddc25 into main Mar 24, 2026
10 checks passed
@jpoehnelt jpoehnelt deleted the fix/cli-publish-paths branch March 24, 2026 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: core Core CLI parsing, commands, error handling, utilities area: skills cla: yes This human has signed the Contributor License Agreement. gemini: reviewed Gemini Code Assist has reviewed the latest changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants