Skip to content

ci: pin cross-rs to v0.2.5 in release workflow#651

Merged
jpoehnelt merged 1 commit intomainfrom
fix/pin-cross-version
Mar 31, 2026
Merged

ci: pin cross-rs to v0.2.5 in release workflow#651
jpoehnelt merged 1 commit intomainfrom
fix/pin-cross-version

Conversation

@jpoehnelt
Copy link
Copy Markdown
Member

The release workflow installed cross from unpinned git HEAD (cargo install cross --git ...), meaning whatever main pointed to at build time was used. A compromised upstream repo could inject malicious code into cross-compiled release binaries (aarch64-linux-gnu, aarch64-linux-musl, x86_64-linux-musl).

Change: Pin to --tag v0.2.5 (latest release).

Part of supply chain hardening effort.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 31, 2026

🦋 Changeset detected

Latest commit: 47ab016

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@googleworkspace/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request improves the security posture of the release pipeline by ensuring that the cross-compilation toolchain uses a specific, verified version rather than the latest commit from the repository. This change mitigates potential supply chain risks associated with building from unpinned sources.

Highlights

  • Supply Chain Security: Pinned the cross-rs dependency to version v0.2.5 in the release workflow to avoid building from unpinned git HEAD.
  • Changelog Update: Added a changeset file to document the dependency pinning for the @googleworkspace/cli package.
Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/release.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Generative AI Prohibited Use Policy, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@googleworkspace-bot googleworkspace-bot added the cla: yes This human has signed the Contributor License Agreement. label Mar 31, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a changeset file documenting the pinning of cross-rs to version 0.2.5 in the release workflow. However, the actual changes to the workflow configuration files are missing from the PR, meaning the intended security improvement has not been implemented.

@github-actions github-actions bot added the gemini: reviewed Gemini Code Assist has reviewed the latest changes label Mar 31, 2026
@jpoehnelt jpoehnelt merged commit b422e5d into main Mar 31, 2026
33 checks passed
@jpoehnelt jpoehnelt deleted the fix/pin-cross-version branch March 31, 2026 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: distribution cla: yes This human has signed the Contributor License Agreement. gemini: reviewed Gemini Code Assist has reviewed the latest changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants