ci: pin cross-rs to v0.2.5 in release workflow#651
Conversation
🦋 Changeset detectedLatest commit: 47ab016 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request improves the security posture of the release pipeline by ensuring that the cross-compilation toolchain uses a specific, verified version rather than the latest commit from the repository. This change mitigates potential supply chain risks associated with building from unpinned sources. Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds a changeset file documenting the pinning of cross-rs to version 0.2.5 in the release workflow. However, the actual changes to the workflow configuration files are missing from the PR, meaning the intended security improvement has not been implemented.
The release workflow installed
crossfrom unpinned git HEAD (cargo install cross --git ...), meaning whatevermainpointed to at build time was used. A compromised upstream repo could inject malicious code into cross-compiled release binaries (aarch64-linux-gnu, aarch64-linux-musl, x86_64-linux-musl).Change: Pin to
--tag v0.2.5(latest release).Part of supply chain hardening effort.