Skip to content

fix: typo in the comment gmail -> drive#335

Closed
morgensternminator wants to merge 1 commit intogoogleworkspace:mainfrom
morgensternminator:patch-1
Closed

fix: typo in the comment gmail -> drive#335
morgensternminator wants to merge 1 commit intogoogleworkspace:mainfrom
morgensternminator:patch-1

Conversation

@morgensternminator
Copy link
Copy Markdown

@morgensternminator morgensternminator commented Jul 6, 2022

There is a typo on the comment where we say we want to create a gmail api client while we are actually trying to create a drive api client.

Description

Fixing a small typo in the comment

Fixes # (issue)

Has it been tested?

  • Development testing done
  • Unit or integration test implemented

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have performed a peer-reviewed with team member(s)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

There is a type on the comment where we say we want to create a gmail api client while we are actually trying to create a drive api client.
@google-cla
Copy link
Copy Markdown

google-cla Bot commented Jul 6, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@morgensternminator morgensternminator changed the title create_drive.py fix type in the comment gmail create_drive.py fix typo in the comment gmail Jul 6, 2022
@conventional-commit-lint-gcf
Copy link
Copy Markdown

conventional-commit-lint-gcf Bot commented Jul 6, 2022

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@morgensternminator morgensternminator changed the title create_drive.py fix typo in the comment gmail fix: create_drive.py fix typo in the comment gmail Jul 6, 2022
@morgensternminator morgensternminator changed the title fix: create_drive.py fix typo in the comment gmail fix: typo in the comment gmail -> drive Jul 6, 2022
Copy link
Copy Markdown

@edel-david edel-david left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

found this typo in another file

try:
# create gmail api client
service = build('drive', 'v3', credentials=creds)

i will try to search for more

@edel-david
Copy link
Copy Markdown

i will try to search for more

i ran rg -A 1 "gmail api" . in the drive folder and it shows 30 results with this comment, all of them should be "drive api"

@jpoehnelt jpoehnelt changed the base branch from master to main July 22, 2022 22:38
@jpoehnelt jpoehnelt mentioned this pull request Jul 28, 2022
@jpoehnelt
Copy link
Copy Markdown

This has been fixed in #350.

@jpoehnelt jpoehnelt closed this Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants