FullUrl regex needs improvement

[junaid-ali]

Describe the bug

Currently, fullUrl returns invalid URLs as valid ones. Same is the case with Url. We should improve the regex like here:
https://github.com/asaskevich/govalidator/blob/master/patterns.go#L41

Examples:

https://www.googl_?e.com/testme
https://www
https://not%23

To Reproduce

Add the above invalid URLs to TestIsFullURL function, the tests will pass.

[junaid-ali]

You can assign the issue to me, I can create a PR.

[junaid-ali]

There's an open PR in the linked repo to further improve that regex: asaskevich/govalidator#451

[inhere]

hi @junaid-ali 😄 Can you create a PR?

[junaid-ali]

@inhere I'm still working on it. The regex in the other repo has some issues as well. What I'm trying to do is: instead of using a complex regex, I'm thinking of updating the method like this

// IsFullURL string.
func IsFullURL(s string) bool {
	if s == "" {
		return false
	}

	u, err := url.Parse(s)
	if err != nil {
		return false
	}

	if u.Scheme != "" && !strings.Contains(URLSchema, u.Scheme) {
		return false
	}

	if ip := net.ParseIP(u.Host); ip == nil {
		return rxDNSName.MatchString(u.Host)
	}

	return false
}

This also has an issue if the URL has a raw percentage sign instead of an HTML encode sign but that should be easy to fix.
I will put up a PR today.

[junaid-ali]

sorry still working on it.

[inhere]

fixed in v2.0