Conversation
|
Skipping CI for Draft Pull Request. |
c6628af to
bdf16c0
Compare
There was a problem hiding this comment.
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
Files not reviewed (1)
- spx-gui/tsconfig.app.json: Language not supported
Comments suppressed due to low confidence (1)
tools/spxls/client.ts:8
- The error message 'unknown message type' is unclear. It should be updated to 'Unknown message type received in handleMessage'.
throw new Error('unknown message type')
20573cd to
4c7726d
Compare
Without cancellationMacbook Air M4 https://goplus-builder.qiniu.io/project/nighca/zombie With cancellationMacbook Air M4 https://goplus-builder.qiniu.io/project/nighca/zombie |
| editorRef, | ||
| (editor, _, onCleanUp) => { | ||
| if (editor == null) return | ||
| editor.init() |
There was a problem hiding this comment.
这里 editor.init() 内部实现多了 registerMCPTools() 后,依赖的项有点多了,还是用 watchEffect 的话会在不预期的时候触发 effect,对应地导致错误
|
|
||
| // Import sentryTracesSampleRate from env.ts instead of defining it locally | ||
| function initSentry() { | ||
| if (process.env.NODE_ENV === 'development') return |
There was a problem hiding this comment.
sentry 会把很多 event handler 包一层以便捕捉事件,影响排查效率,开发的时候关掉
| throw err | ||
| } | ||
| ) | ||
| // TODO: Catch errors on sending, and clear the pending request |
There was a problem hiding this comment.
中间多了 connection 之后感知 sendMessage 的错误会麻烦很多,先不管(考虑我们目前事实上几乎不会遇到这样的错误)
0219872 to
0db1749
Compare
|
This PR has been deployed to the preview environment. You can explore it using the preview URL. Warning Please note that deployments in the preview environment are temporary and will be automatically cleaned up after a certain period. Make sure to explore it before it is removed. For any questions, contact the Go+ Builder team. |
close #1187.