Fix attribute name case for CodeChange#2945
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical parsing issue within the Copilot output by standardizing an attribute name. The change ensures that the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly changes the attribute name in the Zod schema from camelCase (removeLineCount) to kebab-case (remove-line-count) to fix a parsing issue with the <code-change> custom element. The change is appropriate as HTML attributes are typically in kebab-case. I've added a suggestion to further improve the schema's robustness by adding validation for the numeric string format.
There was a problem hiding this comment.
Pull request overview
This PR fixes a Copilot custom element attribute mismatch by updating the <code-change> attributes schema to use kebab-case, aligning the prompt/schema with how markdown/HTML attributes are parsed and sanitized in the UI renderer.
Changes:
- Update
CodeChangecustom element attribute schema key fromremoveLineCounttoremove-line-countto match expected HTML attribute naming.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Clean, minimal, and correct fix. The One suggestion: a regression test covering the attribute name round-trip through the parsing pipeline would catch similar mismatches early. |
Fix attribute parsing failure for
<code-change>in Copilot output.