Skip to content

Fix incomplete rendering for project name#2946

Merged
nighca merged 1 commit intogoplus:devfrom
nighca:dev
Mar 13, 2026
Merged

Fix incomplete rendering for project name#2946
nighca merged 1 commit intogoplus:devfrom
nighca:dev

Conversation

@nighca
Copy link
Copy Markdown
Collaborator

@nighca nighca commented Mar 13, 2026

The owner / project name is not rendered completely:

image

Here we fix it by removing the line-height: 1

@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a visual bug that caused the project name in the editor's navigation bar to be truncated. The change involves a targeted CSS modification to correct the display, ensuring that project names are fully visible to users.

Highlights

  • Rendering Fix: Resolved an issue where the project name was not rendering completely in the editor's navigation bar.
  • CSS Adjustment: Removed the line-height: 1 CSS property from the project display name component to ensure full text visibility.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • spx-gui/src/components/editor/navbar/EditorProjectDisplayName.vue
    • Removed the line-height: 1 CSS property from the .display-name style block.
Activity
  • No specific activity (comments, reviews, or progress updates) has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@nighca nighca marked this pull request as ready for review March 13, 2026 03:19
Copilot AI review requested due to automatic review settings March 13, 2026 03:19
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request attempts to fix a rendering issue with the project name by removing a line-height property. However, this change is likely insufficient because of an inherited style from reset.css. I've provided a review comment with a suggested change to properly fix the text rendering by setting an explicit, larger line-height.

Comment thread spx-gui/src/components/editor/navbar/EditorProjectDisplayName.vue
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes a UI/CSS rendering issue in the editor navbar where the owner/project name text was being visually clipped, preventing it from rendering fully.

Changes:

  • Removes line-height: 1 from the shared styles applied to the owner and project name text in the navbar display.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@fennoai
Copy link
Copy Markdown
Contributor

fennoai Bot commented Mar 13, 2026

Clean, minimal, and correct fix. Removing line-height: 1 is the right call — the parent .project-pill uses display: inline-flex with align-items: center, so vertical alignment is already handled by flexbox and pinning line-height to exactly the font size was unnecessarily clipping ascenders/descenders.

Minor: the PR title and commit message contain a typo — "imcomplete" should be "incomplete".

@nighca nighca changed the title Fix imcomplete rendering for project name Fix incomplete rendering for project name Mar 13, 2026
@nighca nighca enabled auto-merge (squash) March 13, 2026 03:27
@nighca nighca merged commit b135541 into goplus:dev Mar 13, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants