Fix incomplete rendering for project name#2946
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a visual bug that caused the project name in the editor's navigation bar to be truncated. The change involves a targeted CSS modification to correct the display, ensuring that project names are fully visible to users. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request attempts to fix a rendering issue with the project name by removing a line-height property. However, this change is likely insufficient because of an inherited style from reset.css. I've provided a review comment with a suggested change to properly fix the text rendering by setting an explicit, larger line-height.
There was a problem hiding this comment.
Pull request overview
Fixes a UI/CSS rendering issue in the editor navbar where the owner/project name text was being visually clipped, preventing it from rendering fully.
Changes:
- Removes
line-height: 1from the shared styles applied to the owner and project name text in the navbar display.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Clean, minimal, and correct fix. Removing Minor: the PR title and commit message contain a typo — "imcomplete" should be "incomplete". |
The owner / project name is not rendered completely:
Here we fix it by removing the
line-height: 1