feat(asset-library): add search recommendations for asset types#3012
Merged
nighca merged 1 commit intogoplus:devfrom Apr 9, 2026
Merged
feat(asset-library): add search recommendations for asset types#3012nighca merged 1 commit intogoplus:devfrom
nighca merged 1 commit intogoplus:devfrom
Conversation
nighca
commented
Apr 8, 2026
| { en: 'UI', zh: '界面' } | ||
| ], | ||
| [AssetType.Sound]: [ | ||
| // TODO: discussion needed |
Collaborator
Author
There was a problem hiding this comment.
目前声音的搜索效果不好，没有合适的 recommendation 项
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request replaces the getAssetCategories utility with a static searchRecommendations object to provide search suggestions in the asset library. The review identifies a critical issue where AssetType and LocaleMessage are used in a new script block without being imported, which will cause reference errors. Additionally, it is recommended to use unique keys instead of array indices in the v-for loop to adhere to Vue best practices.
![xgopilot[bot]](https://avatars.githubusercontent.com/in/1924301?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.