Skip to content

docs: fix JSDoc for convertScratchToXbp#3092

Merged
nighca merged 3 commits into
devfrom
fork-pr-3090-1777340024
Apr 28, 2026
Merged

docs: fix JSDoc for convertScratchToXbp#3092
nighca merged 3 commits into
devfrom
fork-pr-3090-1777340024

Conversation

@fennoai
Copy link
Copy Markdown
Contributor

@fennoai fennoai Bot commented Apr 28, 2026

Requested by @nighca

Fixes review comments on #3090.

Summary

  • Fix endpoint path in JSDoc: /scratch-convert/util/sb2xbp
  • Update timeout description: the function now uses a custom 60-second timeout (overriding the shared 10-second default), so the previous claim that "timeout behavior are consistent with other APIs" is no longer accurate

go-wyvern and others added 2 commits April 28, 2026 09:32
- Fix endpoint path: /scratch-convert -> /util/sb2xbp
- Update timeout description to reflect custom 60s timeout

Generated with [codeagent](https://github.com/qbox/codeagent)
Co-authored-by: nighca <1492263+nighca@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

@fennoai fennoai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR correctly fixes two JSDoc inaccuracies from #3090: the endpoint path (/scratch-convert/util/sb2xbp) and the timeout description. The changes are accurate and the constant naming is clear.

A few notes below, mostly pre-existing issues surfaced by the diff.

Comment thread spx-gui/src/apis/sb2xbp.ts Outdated
Comment thread spx-gui/src/apis/sb2xbp.ts
Comment thread spx-gui/src/apis/sb2xbp.ts
Co-authored-by: fennoai[bot] <231223108+fennoai[bot]@users.noreply.github.com>
@nighca nighca merged commit 2357c98 into dev Apr 28, 2026
7 checks passed
@fennoai fennoai Bot deleted the fork-pr-3090-1777340024 branch April 28, 2026 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants