fix(spx-gui): fix UIIcon tooltip trigger resolution & support SVG popup triggers#3197
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request generalizes the popup trigger logic by replacing HTMLElement with Element and Node types across several UI components and utilities. These changes allow the system to support SVG elements as triggers and correctly handle Vue development mode scenarios where a component's root might be a comment or text node. A new helper function, resolveElementFromComponentRoot, has been implemented to traverse the DOM and locate the first valid element when an anchor node is provided. Additionally, new unit tests have been introduced to verify these improvements. I have no feedback to provide as there were no review comments to evaluate.
![fennoai[bot]](https://avatars.githubusercontent.com/in/1924301?s=60&v=4){kind=small}
nighca
reviewed
May 21, 2026
cn0809
changed the title
nighca
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.