feat(spx-gui): support incomplete completion lists#3306
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
![fennoai[bot]](https://avatars.githubusercontent.com/in/1924301?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
nighca
approved these changes
Jun 30, 2026
aofei
force-pushed
the
support-incomplete-completion-lists
branch
2 times, most recently
from
3788a25 to
41aadb6
Compare
Normalize LSP completion results to `CompletionList` so array results keep existing complete-list behavior while incomplete lists can trigger a fresh request during active completion. Fixes goplus#3256 Signed-off-by: Aofei Sheng <aofei@aofeisheng.com>
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
aofei
force-pushed
the
support-incomplete-completion-lists
branch
from
41aadb6 to
54d281f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Normalize LSP completion results to
CompletionListso array results keep existing complete-list behavior while incomplete lists can trigger a fresh request during active completion.Fixes #3256