refactor(Project): abort previous saveToCloud before starting a new one#836
Merged
nighca merged 1 commit intogoplus:devfrom Sep 2, 2024
Merged
refactor(Project): abort previous saveToCloud before starting a new one#836nighca merged 1 commit intogoplus:devfrom
saveToCloud before starting a new one#836nighca merged 1 commit intogoplus:devfrom
Conversation
aofei
commented
Sep 2, 2024
nighca
reviewed
Sep 2, 2024
| this.addDisposer(retryAutoSave.cancel) | ||
|
|
||
| this.addDisposer( | ||
| watch( |
Collaborator
There was a problem hiding this comment.
这里的意图我没太理解，在 isSavingToCloud 变为 true（应该意味着 saveToCloud 开始执行）的时候立即执行一次 retryAutoSave / save？
Member
Author
There was a problem hiding this comment.
在
isSavingToCloud变为true（应该意味着saveToCloud开始执行）的时候立即执行一次retryAutoSave/save？
是的。这里的目的是，当主动保存发生时，让 autoSaveToCloudState 从 Failed/Pending 立即进入到 Saving
Member
Author
There was a problem hiding this comment.
… one This also improves the auto-save mechanism by making it reactive to the `saveToCloud` process. Fixes goplus#796 Signed-off-by: Aofei Sheng <aofei@aofeisheng.com>
|
The PR environment is ready, please check the PR environment [Attention]: This environment will be automatically cleaned up after a certain period of time., please make sure to test it in time. If you have any questions, please contact the builder team. |
nighca
approved these changes
Sep 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also improves the auto-save mechanism by making it reactive to the
saveToCloudprocess.Fixes #796