test: add make:event broadcast test cases (framework#1532) - #140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
make:event --broadcastnow scaffolds a broadcasting event (implementingBroadcastOn,BroadcastAs,BroadcastWith, andBroadcastWhen), and--broadcast --nowadditionally scaffoldsBroadcastNowreturningtrue; both are covered by new feature tests.[]stringinstead of the removedcontracts.Channelstruct.v1.18.1-0.20260805080351-d2e95f66f306pseudo-version containing framework#1532 (make:eventbroadcast/now flags and the broadcasting channel refactor).Why
Framework PR goravel/framework#1532 adds
--broadcastand--broadcast --nowflags to themake:eventcommand and replaces thebroadcasting.Channelstruct with plain[]stringchannels. The example repository must stay in sync with that API so the generated events compile and demonstrate the new scaffolding.The example's broadcast events now return
[]stringchannels, and the event feature suite gains coverage for both new command flags, verifying the scaffolded file contents (broadcast methods present, listener-only methods absent, andBroadcastNowreturningtrueonly for the--nowvariant).