fix: resolve PIE moduledata pointer fields using generated offsets#121
Merged
Conversation
The previous commit resolved type pointer fields but applied resolveBuffer blindly to all moduledata words, corrupting len/cap integer fields. - Generate pointerOffsets() on each versioned moduledata struct, returning byte offsets of fields that are actual pointers (from AST: *T, []T data ptr, uintptr, string data ptr) vs integer counts - Add pointerOffsets() to the modulable interface - In extractModuledata, resolve only pointer fields before binary.Read so derived values like TextLen = Etext - Text compute correctly - Remove resolveBuffer (blind whole-struct resolution) - Replace findModuledataByChainedFixup with generic findPointerValue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.