Skip to content

Skip local blob server for cloud stores#1285

Merged
zhenghaoz merged 3 commits into
gorse-io:masterfrom
zhangzhenghao:fix/cloud-blob-master-server
Jun 10, 2026
Merged

Skip local blob server for cloud stores#1285
zhenghaoz merged 3 commits into
gorse-io:masterfrom
zhangzhenghao:fix/cloud-blob-master-server

Conversation

@zhangzhenghao

Copy link
Copy Markdown
Contributor

Summary

  • skip the legacy local blob gRPC server when [blob].uri uses a cloud URI scheme
  • avoid registering a nil blob server in that case
  • add coverage that cloud URIs do not create a local s3: directory while local paths still create a blob server

Fixes #1283

Test Plan

  • /usr/local/go/bin/go test ./master -run TestNewMasterBlobServer -count=1
  • /usr/local/go/bin/go test ./master -run TestMaster -count=1
  • /usr/local/go/bin/go test ./... -run '^$'
  • git diff --check

@codecov

codecov Bot commented Jun 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.96%. Comparing base (054c37b) to head (6eadd1b).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1285      +/-   ##
==========================================
- Coverage   74.07%   73.96%   -0.11%     
==========================================
  Files          92       92              
  Lines       17256    17258       +2     
==========================================
- Hits        12782    12765      -17     
- Misses       3155     3167      +12     
- Partials     1319     1326       +7     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zhenghaoz zhenghaoz changed the title fix(master): skip local blob server for cloud stores Skip local blob server for cloud stores Jun 10, 2026
@zhenghaoz
zhenghaoz merged commit 646d2a7 into gorse-io:master Jun 10, 2026
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Master crashes on startup when [blob] uri is cloud (s3://, gs://, az://) and the rootfs is read-only

2 participants