Skip to content

Bar pack v4 refresh + crowd sound reactions#940

Merged
byrongamatos merged 3 commits into
mainfrom
feat/bar-pack-v4-refresh
Jul 13, 2026
Merged

Bar pack v4 refresh + crowd sound reactions#940
byrongamatos merged 3 commits into
mainfrom
feat/bar-pack-v4-refresh

Conversation

@byrongamatos

@byrongamatos byrongamatos commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Final piece of the career-mode stack (after #905, #907, #927).

  • Pack v4 media: per-character desynced animation starts across all six loops, flyover intro, and per-venue reaction recordings (`sfx-up.mp3` cheer / `sfx-down.mp3` boo) declared in `manifest.sfx`.
  • Crowd sound reactions runtime (`static/v3/venue-crowd.js`): on a committed mood transition, plays the venue's own cheer (up) or boo (down). Committed transitions are hysteresis-limited, so it can't spam. Gated by the `feedBack-venue-crowd-sfx` setting, default off.
  • Settings toggle restored: the crowd-sound-reactions checkbox was dropped when `settings.html` became the passports data panel; re-added beneath it.

Codex preflight clean; 995/995 `node --test tests/js/**` + 23/23 career pytest.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • New Features
    • Added an optional “Crowd sound reactions” setting for the Career plugin.
    • Added crowd mood sound effects that play when the audience mood improves or declines.
    • Added support for configuring upward and downward crowd reaction sounds per venue.
    • Crowd sounds can be enabled or disabled and are skipped when unavailable or during introductions.

byrongamatos and others added 3 commits July 13, 2026 14:23
Pack v4: per-character desynced animation starts, flyover intro,
per-venue reaction sounds (sfx-up/sfx-down in manifest).
Settings: re-add the crowd sound reactions toggle that was dropped
when settings.html became the passports data panel.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Port the venue-crowd SFX runtime that the settings toggle and the
pack's sfx-up/sfx-down files were built for: on a committed mood
transition, play the venue's own cheer (up) or boo (down) one-shot,
gated by the feedBack-venue-crowd-sfx setting (default off).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 1f100d09-5f27-4084-9441-19454feaf008

📥 Commits

Reviewing files that changed from the base of the PR and between 8f1906a and 566b2a3.

⛔ Files ignored due to path filters (8)
  • plugins/career/venue-packs/bar/bored.mp4 is excluded by !**/*.mp4
  • plugins/career/venue-packs/bar/cheer.mp4 is excluded by !**/*.mp4
  • plugins/career/venue-packs/bar/clap.mp4 is excluded by !**/*.mp4
  • plugins/career/venue-packs/bar/ecstatic.mp4 is excluded by !**/*.mp4
  • plugins/career/venue-packs/bar/engaged.mp4 is excluded by !**/*.mp4
  • plugins/career/venue-packs/bar/neutral.mp4 is excluded by !**/*.mp4
  • plugins/career/venue-packs/bar/sfx-down.mp3 is excluded by !**/*.mp3
  • plugins/career/venue-packs/bar/sfx-up.mp3 is excluded by !**/*.mp3
📒 Files selected for processing (4)
  • plugins/career/settings.html
  • plugins/career/venue-packs/bar/manifest.json
  • static/tailwind.min.css
  • static/v3/venue-crowd.js

📝 Walkthrough

Walkthrough

Adds a Career settings toggle, venue manifest sound mappings, and crowd runtime playback for directional mood sound effects, with localStorage guards and cleanup on venue stop.

Changes

Crowd sound reactions

Layer / File(s) Summary
SFX configuration and toggle
plugins/career/settings.html, plugins/career/venue-packs/bar/manifest.json, static/tailwind.min.css
Adds the crowd sound reactions checkbox, persists its localStorage value, configures bar venue up/down MP3 files, and refreshes the bundled stylesheet.
Directional SFX runtime
static/v3/venue-crowd.js
Reads the SFX preference, normalizes manifest sound URLs, plays sounds after committed mood transitions, and pauses active audio during stop().
Estimated code review effort: 3 (Moderate) ~20 minutes

Sequence Diagram(s)

sequenceDiagram
  participant CareerSettings
  participant localStorage
  participant v3VenueCrowd
  participant venueManifest
  participant HTMLAudioElement
  CareerSettings->>localStorage: Persist feedBack-venue-crowd-sfx on/off
  v3VenueCrowd->>venueManifest: Read normalized sfx.up/down URLs
  v3VenueCrowd->>localStorage: Check SFX toggle
  v3VenueCrowd->>HTMLAudioElement: Play directional mood reaction
  v3VenueCrowd->>HTMLAudioElement: Pause audio during stop()
Loading

Possibly related PRs

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/bar-pack-v4-refresh

Comment @coderabbitai help to get the list of available commands.

@byrongamatos
byrongamatos merged commit 45caa86 into main Jul 13, 2026
5 of 6 checks passed
@byrongamatos
byrongamatos deleted the feat/bar-pack-v4-refresh branch July 13, 2026 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant