Bar pack v4 refresh + crowd sound reactions#940
Merged
Conversation
Pack v4: per-character desynced animation starts, flyover intro, per-venue reaction sounds (sfx-up/sfx-down in manifest). Settings: re-add the crowd sound reactions toggle that was dropped when settings.html became the passports data panel. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Port the venue-crowd SFX runtime that the settings toggle and the pack's sfx-up/sfx-down files were built for: on a committed mood transition, play the venue's own cheer (up) or boo (down) one-shot, gated by the feedBack-venue-crowd-sfx setting (default off). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (8)
📒 Files selected for processing (4)
📝 WalkthroughWalkthroughAdds a Career settings toggle, venue manifest sound mappings, and crowd runtime playback for directional mood sound effects, with localStorage guards and cleanup on venue stop. ChangesCrowd sound reactions
Sequence Diagram(s)sequenceDiagram
participant CareerSettings
participant localStorage
participant v3VenueCrowd
participant venueManifest
participant HTMLAudioElement
CareerSettings->>localStorage: Persist feedBack-venue-crowd-sfx on/off
v3VenueCrowd->>venueManifest: Read normalized sfx.up/down URLs
v3VenueCrowd->>localStorage: Check SFX toggle
v3VenueCrowd->>HTMLAudioElement: Play directional mood reaction
v3VenueCrowd->>HTMLAudioElement: Pause audio during stop()
Possibly related PRs
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Final piece of the career-mode stack (after #905, #907, #927).
Codex preflight clean; 995/995 `node --test tests/js/**` + 23/23 career pytest.
🤖 Generated with Claude Code
Summary by CodeRabbit