Show routes welsh live archived pages#2811
Merged
Merged
Conversation
These changes will affect forms that are in a group with multiple branches enabled, and that have a Welsh live version available.
SamJamCul
force-pushed
the
show-routes-welsh-live-archived-pages
branch
from
c779b86 to
82357f2
Compare
If a none of the above answer value was used in the bilingual table displaying live pages, we were showing `none_of_the_above` rather than the appropriate `None of the above`. Additionally, we should show the Welsh translation for this, `Dim un o’r uchod` on the Welsh side of the table accordingly.
SamJamCul
force-pushed
the
show-routes-welsh-live-archived-pages
branch
from
82357f2 to
4902c7c
Compare
lfdebrux
reviewed
May 28, 2026
lfdebrux
reviewed
May 28, 2026
|
🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-2811.admin.review.forms.service.gov.uk/ It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready For the sign in details and more information, see the review apps wiki page. |
Contributor
|
It looks right to me - from a design perspective :) |
lfdebrux
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this pull request solve?
https://trello.com/c/LtIlAUBk/3072-show-new-routes-in-live-archived-view
For groups with multiple branches enabled, forms that have a live/archived Welsh version will show new table format.
Additionally fixed some issues with how we were displaying
None of the abovein these tables. In fact, that page just didn't work!Before
After
Things to consider when reviewing