Fix row order for Welsh form CSV#2812
Merged
SamJamCul merged 1 commit intoMay 28, 2026
Merged
Conversation
The correct order for a question's details in a CSV is - Page heading - Guidance text - Question text - Hint text (if relevant) - List of options (if relevant) This matches how the translations are displayed on the Welsh Translations page The test for this has switched from using `match_array` to `eq` so that the ordering is taken into account.
|
🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-2812.admin.review.forms.service.gov.uk/ It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready For the sign in details and more information, see the review apps wiki page. |
lfdebrux
approved these changes
May 28, 2026
Contributor
|
Slick! Thanks for figuring that out. |
Contributor
|
looks good to me! |
SamJamCul
deleted the
content-for-guidance-questions-not-in-same-order-on-welsh-csv-as-on-add-welsh-content-page
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://trello.com/c/JYUtlVzE/3117-content-for-guidance-questions-not-in-same-order-on-welsh-csv-as-on-add-welsh-content-page
The correct order for a question's details in a CSV is
This matches how the translations are displayed on the Welsh Translations page
The test for this has switched from using
match_arraytoeqso that the ordering is taken into account.