Skip to content

Conversation

@ByteHamster
Copy link
Contributor

@ByteHamster ByteHamster commented Oct 3, 2020

Linking the devices works but the very last step (sync_user.delay(user)) still fails with:

TypeError: Object of type User is not JSON serializable

When using sync_user.delay(user.pk) like it is used elsewhere, the request blocks indefinitely.

sync_user.delay(request.user.pk)

Closes #128

@ByteHamster ByteHamster changed the title Fix sync API WIP: Fix sync API Oct 3, 2020
@ByteHamster
Copy link
Contributor Author

@fundatillus Do you have an idea how to fix the sync_user.delay part?

That would be the only thing missing to make gpodder integration in AntennaPod a lot easier to understand for users. We currently get quite a few requests by users who do not know that they need to link devices with the web UI to make synchronization work. Would be great if AntennaPod could link automatically using the API.

@keunes
Copy link
Contributor

keunes commented Dec 30, 2020

@fundatillus I saw you merged some human-made PRs recently. This fix is required for some improvements in AntennaPod related to the gpodder.net integration (even beyond what's described above). It would be great if this could be merged. Would you be in the position to have a look?

@clementsjosh clementsjosh merged commit f9a89d3 into gpodder:master Dec 30, 2020
@clementsjosh
Copy link

@fundatillus I saw you merged some human-made PRs recently. This fix is required for some improvements in AntennaPod related to the gpodder.net integration (even beyond what's described above). It would be great if this could be merged. Would you be in the position to have a look?

Done! I'll push to prod soon.

@ByteHamster
Copy link
Contributor Author

This was a WIP PR. While it does fix one issue, the API is still broken and #128 should not be closed. Unfortunately, I do not know enough about the framework to find out why sync_user.delay(user.pk) does not work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

API: Device Synchronization API - Start / Stop Sync returning HTTP status 500

3 participants